Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a module outputs to a temporary file using "Path().stat().st_size > 0" #2224

Merged
merged 4 commits into from
Dec 10, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 5, 2022

Description of proposed changes

Fixes #1912

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 5, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 5, 2022
@seisman seisman force-pushed the check-tmpfile-size branch from fb79af2 to dca5646 Compare December 6, 2022 05:10
@seisman seisman changed the title WIP: Replace os.path.exists() with Path().stat().st_size > 0 Check if a module outputs to a temporary file using "Path().stat().st_size > 0" Dec 6, 2022
@seisman seisman marked this pull request as ready for review December 6, 2022 05:11
@seisman seisman force-pushed the check-tmpfile-size branch from dca5646 to 6ccdccd Compare December 6, 2022 05:17
@seisman seisman added the needs review This PR has higher priority and needs review. label Dec 7, 2022
@seisman seisman requested a review from a team December 9, 2022 03:09
@willschlitzer willschlitzer added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 9, 2022
@seisman seisman merged commit 09ce111 into main Dec 10, 2022
@seisman seisman deleted the check-tmpfile-size branch December 10, 2022 02:04
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking the existence of GMTTempFile using "os.path.exists" is invalid
4 participants