Convert module request issue template into yaml configured form #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
approved these changes
Nov 30, 2022
Comment on lines
31
to
42
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| **Checklist for wrapping GMT Module** | ||
|
|
||
| <!-- Please do not edit this section when submitting pull requests. This checklist will help track progress on wrapping the module. --> | ||
|
|
||
| - [ ] 'Initial feature implementation' Pull Request (PR) | ||
| - [ ] 'Add missing aliases to module' documentation PR | ||
| - [ ] 'Support additional functionality in module' PR (optional) | ||
| - [ ] 'Add gallery example for module' documentation PR | ||
| - [ ] 'Add tutorial for module' documentation PR (optional) |
There was a problem hiding this comment.
Just want to confirm that we want to keep this section in the feature request template, versus using the project board as suggested #1687 (comment). I don't have a strong opinion here, but if we are going to remove it in favor of the project board now's a good time to do so.
There was a problem hiding this comment.
I'm OK with using the project board. We can remove this checklist and add a link to the project board.
seisman
force-pushed
the
yaml-module-request
branch
from
4435918 to
08615d5
Compare
michaelgrund
approved these changes
Dec 5, 2022
seisman
added
final review call
willschlitzer
approved these changes
Dec 5, 2022
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Address #2050.
Preview at https://github.com/GenericMappingTools/pygmt/blob/yaml-module-request/.github/ISSUE_TEMPLATE/module_request.yaml
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version