Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add "fillpositive"/"fillnegative" #2205

Merged
merged 19 commits into from
Dec 27, 2022

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Nov 23, 2022

Description of proposed changes

Addresses #1617.

Parameter color is deprecated and replaced by the two new parameters

  • fillpositive and
  • fillnegative.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added deprecation Deprecating a feature skip-changelog Skip adding Pull Request to changelog labels Nov 23, 2022
@michaelgrund michaelgrund added this to the 0.8.0 milestone Nov 23, 2022
@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs and removed deprecation Deprecating a feature labels Nov 23, 2022
@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Nov 23, 2022
pygmt/src/wiggle.py Outdated Show resolved Hide resolved
@seisman seisman added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 25, 2022
@seisman seisman marked this pull request as draft November 30, 2022 10:25
@seisman
Copy link
Member

seisman commented Dec 20, 2022

I'd like to see this PR being merged into the main branch before the v0.8.0 release. Do you think you have time to finish it in the next few days? @michaelgrund

@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 20, 2022
65 tasks
@michaelgrund
Copy link
Member Author

I'd like to see this PR being merged into the main branch before the v0.8.0 release. Do you think you have time to finish it in the next few days? @michaelgrund

Yes will work on it end of the week @seisman.

@michaelgrund michaelgrund changed the title Figure.wiggle: Deprecate parameter "color" to "fill" (remove in v0.12.0) Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add fill_positive/fill_negative Dec 23, 2022
@michaelgrund michaelgrund changed the title Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add fill_positive/fill_negative Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add "fill_positive"/"fill_negative" Dec 23, 2022
@michaelgrund michaelgrund marked this pull request as ready for review December 23, 2022 15:43
@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Dec 23, 2022
@seisman
Copy link
Member

seisman commented Dec 24, 2022

Still need to add some tests to check what happens when color and fill_positive/fill_negative are used.

pygmt/src/wiggle.py Outdated Show resolved Hide resolved
@michaelgrund
Copy link
Member Author

Still need to add some tests to check what happens when color and fill_positive/fill_negative are used.

Done @seisman !

pygmt/src/wiggle.py Outdated Show resolved Hide resolved
pygmt/src/wiggle.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund changed the title Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add "fill_positive"/"fill_negative" Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add "fillpositive"/"fillnegative" Dec 25, 2022
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 26, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 27, 2022
@seisman seisman enabled auto-merge (squash) December 27, 2022 02:17
@seisman seisman disabled auto-merge December 27, 2022 02:17
@seisman seisman merged commit 25fab2e into main Dec 27, 2022
@seisman seisman deleted the wiggle-deprecate-color-to-fill branch December 27, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants