-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.wiggle: Deprecate parameter "color" (remove in v0.12.0) and add "fillpositive"/"fillnegative" #2205
Conversation
/format |
I'd like to see this PR being merged into the main branch before the v0.8.0 release. Do you think you have time to finish it in the next few days? @michaelgrund |
Yes will work on it end of the week @seisman. |
Still need to add some tests to check what happens when |
Done @seisman ! |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Description of proposed changes
Addresses #1617.
Parameter
color
is deprecated and replaced by the two new parametersfillpositive
andfillnegative
.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version