Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.plot3d: Deprecate parameter "color" to "fill" (remove in v0.12.0) #2178

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 30, 2022

Description of proposed changes

Related to #1617.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Oct 30, 2022
@seisman seisman added this to the 0.8.0 milestone Oct 30, 2022
@seisman
Copy link
Member Author

seisman commented Nov 4, 2022

Ping @GenericMappingTools/pygmt-maintainers for a final review because plot3d is widely used so the deprecation will affect many users.

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine!

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Nov 4, 2022
@weiji14
Copy link
Member

weiji14 commented Nov 4, 2022

Can we rename the PR title to "Figure.plot3d: Deprecate parameter "color" to "fill" (remove in v0.12.0)", since this is just a deprecation warning and not a full removal yet?

@seisman seisman changed the title Figure.plot3d: Remove parameter "color", use "fill" instead Figure.plot3d: Deprecate parameter "color" to "fill" (remove in v0.12.0) Nov 5, 2022
@seisman seisman merged commit bb99f7a into main Nov 7, 2022
@seisman seisman deleted the plot3d-deprecate-color-to-fill branch November 7, 2022 11:21
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants