Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions to install pygmt kernel for Jupyter users #2153

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Add instructions to install pygmt kernel for Jupyter users #2153

merged 3 commits into from
Oct 13, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 9, 2022

Description of proposed changes

Fixes #2113

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the documentation Improvements or additions to documentation label Oct 9, 2022
@seisman seisman added this to the 0.8.0 milestone Oct 9, 2022
@seisman seisman requested a review from weiji14 October 9, 2022 15:25
willschlitzer
willschlitzer reviewed Oct 9, 2022
View reviewed changes
doc/install.rst Outdated Show resolved Hide resolved
@seisman @willschlitzer
Update doc/install.rst
af3211f 
Co-authored-by: Will Schlitzer <[email protected]>
willschlitzer
willschlitzer approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've never dealt with this issue, but I assume the instructions are accurate.

doc/install.rst Outdated Show resolved Hide resolved
weiji14
weiji14 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, just one minor wording change.

doc/install.rst Outdated Show resolved Hide resolved
@seisman @weiji14 @willschlitzer
Apply suggestions from code review
b18bc9c 
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Will Schlitzer <[email protected]>
@seisman seisman merged commit 3ec107b into main Oct 13, 2022
@seisman seisman deleted the pygmt-kernel branch October 13, 2022 02:42
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @willschlitzer @weiji14
Add instructions to install pygmt kernel for Jupyter users (GenericMa…
74b582d 
…ppingTools#2153)

Co-authored-by: Will Schlitzer <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willschlitzer willschlitzer willschlitzer approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

import pygmt raises ModuleNotFoundError in Jupyter
3 participants
@seisman @weiji14 @willschlitzer