-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default for pen
parameter in API documentation
#2134
Conversation
I am unsure about making this change in the upstream GMT documentation. I realized that it is possible to use |
The upstream GMT maintainers also agree that we should use |
Thanks @seisman for your response and the links to the upstream GMT PRs. I opened a PR to make this change in the upstream GMT documentation. |
Description of proposed changes
This PR aims to fix the default for the
pen
parameter in the API documentation.Default pen:
width = default
, color = black, style = solid
also occurs in the upstream GMT documentation (e.g. https://docs.generic-mapping-tools.org/dev/coast.html#i). If the change to
Default pen:
width = 0.25p
, color = black, style = solid
is correct, I can try to open an corresponding PR in the next days.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version