Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for pen parameter in API documentation #2134

Merged
merged 4 commits into from
Sep 25, 2022
Merged

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR aims to fix the default for the pen parameter in the API documentation.

Default pen: width = default, color = black, style = solid
also occurs in the upstream GMT documentation (e.g. https://docs.generic-mapping-tools.org/dev/coast.html#i). If the change to
Default pen: width = 0.25p, color = black, style = solid
is correct, I can try to open an corresponding PR in the next days.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Sep 24, 2022
@seisman seisman added this to the 0.8.0 milestone Sep 24, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 24, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 25, 2022
@seisman seisman merged commit 001822f into main Sep 25, 2022
@seisman seisman deleted the fix-typos-04 branch September 25, 2022 13:13
@yvonnefroehlich
Copy link
Member Author

This PR aims to fix the default for the pen parameter in the API documentation.

Default pen: width = default, color = black, style = solid also occurs in the upstream GMT documentation (e.g. https://docs.generic-mapping-tools.org/dev/coast.html#i). If the change to Default pen: width = 0.25p, color = black, style = solid is correct, I can try to open an corresponding PR.

I am unsure about making this change in the upstream GMT documentation. I realized that it is possible to use default for the pen attribute width. However, from a user perspective, I feel a more descriptive argument would be nice, i. e. 0.25p (or at least thinnest), even user can look this up at https://docs.generic-mapping-tools.org/6.4/cookbook/features.html#wpen-attrib.
Ping @GenericMappingTools/pygmt-maintainers for thoughts on this, please.

@seisman
Copy link
Member

seisman commented Nov 4, 2022

This PR aims to fix the default for the pen parameter in the API documentation.
Default pen: width = default, color = black, style = solid also occurs in the upstream GMT documentation (e.g. https://docs.generic-mapping-tools.org/dev/coast.html#i). If the change to Default pen: width = 0.25p, color = black, style = solid is correct, I can try to open an corresponding PR.

I am unsure about making this change in the upstream GMT documentation. I realized that it is possible to use default for the pen attribute width. However, from a user perspective, I feel a more descriptive argument would be nice, i. e. 0.25p (or at least thinnest), even user can look this up at https://docs.generic-mapping-tools.org/6.4/cookbook/features.html#wpen-attrib. Ping @GenericMappingTools/pygmt-maintainers for thoughts on this, please.

The upstream GMT maintainers also agree that we should use 0.25p rather than default when talking about the default pen width. See GenericMappingTools/gmt#4006 and GenericMappingTools/gmt#3993.

@yvonnefroehlich
Copy link
Member Author

This PR aims to fix the default for the pen parameter in the API documentation.
Default pen: width = default, color = black, style = solid also occurs in the upstream GMT documentation (e.g. https://docs.generic-mapping-tools.org/dev/coast.html#i). If the change to Default pen: width = 0.25p, color = black, style = solid is correct, I can try to open an corresponding PR.

I am unsure about making this change in the upstream GMT documentation. I realized that it is possible to use default for the pen attribute width. However, from a user perspective, I feel a more descriptive argument would be nice, i. e. 0.25p (or at least thinnest), even user can look this up at https://docs.generic-mapping-tools.org/6.4/cookbook/features.html#wpen-attrib. Ping @GenericMappingTools/pygmt-maintainers for thoughts on this, please.

The upstream GMT maintainers also agree that we should use 0.25p rather than default when talking about the default pen width. See GenericMappingTools/gmt#4006 and GenericMappingTools/gmt#3993.

Thanks @seisman for your response and the links to the upstream GMT PRs. I opened a PR to make this change in the upstream GMT documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants