Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary typecheck settings for pylint #2120

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 17, 2022

Description of proposed changes

We added pylint settings generated-members="pandas.*" in #1755 (comment) to silent annoying pylint messages. It seems recent versions of pylint no longer report these messages, so we can remove the settings.

@seisman seisman marked this pull request as ready for review September 17, 2022 16:02
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 17, 2022
@seisman seisman added this to the 0.8.0 milestone Sep 17, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can confirm that running make lint locally doesn't throw up any errors. Tested using pylint=2.15.0 and astroid=2.12.5.

@seisman seisman merged commit 9a986ba into main Sep 18, 2022
@seisman seisman deleted the remove-pylint-typecheck branch September 18, 2022 23:46
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants