Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges for conda package version, license and twitter #2081

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Add badges for conda package version, license and twitter #2081

merged 2 commits into from
Aug 26, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 24, 2022 •
edited
Loading

Description of proposed changes

  1. Change the "Install with conda" badge to the "conda package version" badge so that we know the pygmt conda package is up-to-date
  2. Add a badge for the project license
  3. Add a social badge which is linked to twitter @gmt_dev

Before:
image

After

image

Edit:

New version:
image

@seisman seisman added the maintenance Boring but important stuff for the core devs label Aug 24, 2022
@seisman seisman added this to the 0.8.0 milestone Aug 24, 2022
@seisman seisman added the needs review This PR has higher priority and needs review. label Aug 25, 2022
michaelgrund
michaelgrund approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Aug 25, 2022
maxrjones
maxrjones approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one suggestion, but seems good either way

README.rst Outdated Show resolved Hide resolved
@seisman @maxrjones
Update README.rst
86f1791 
Co-authored-by: Max Jones <[email protected]>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 26, 2022
@seisman seisman merged commit 2817d6a into main Aug 26, 2022
@seisman seisman deleted the badges branch August 26, 2022 14:20
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @maxrjones
Add badges for conda package version, license and twitter (GenericMap…
57c7580 
…pingTools#2081)

Co-authored-by: Max Jones <[email protected]>
@weiji14 weiji14 added documentation Improvements or additions to documentation and removed maintenance Boring but important stuff for the core devs labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@seisman @maxrjones @michaelgrund @weiji14