Add a workflow and Makefile target to test old GMT versions every Tuesday #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
seisman
changed the title
seisman
commented
Aug 24, 2022
seisman
commented
Aug 27, 2022
seisman
commented
Aug 27, 2022
seisman
commented
Aug 28, 2022
seisman
force-pushed
the
test-old-gmt-versions
branch
from
9f19869 to
8d3cf45
Compare
seisman
changed the title
maxrjones
reviewed
Aug 28, 2022
weiji14
reviewed
Aug 28, 2022
maxrjones
reviewed
Aug 28, 2022
Co-authored-by: Max Jones <[email protected]>
seisman
changed the title
seisman
commented
Aug 29, 2022
seisman
commented
Aug 29, 2022
seisman
commented
Aug 31, 2022
|
Ping @weiji14 and @maxrjones for another round of review. |
weiji14
reviewed
Sep 9, 2022
| @@ -0,0 +1,105 @@ | |||
| # This workflow installs PyGMT and runs tests with old GMT versions | |||
|
|
|||
| name: GMT Backward Tests | |||
There was a problem hiding this comment.
Not so sure if 'backward' is a good word, how about 'legacy' (https://en.wikipedia.org/wiki/Legacy_system)? Maybe we need to ask a native English speaker 🙂
Suggested change
| name: GMT Backward Tests | |
| name: GMT Legacy Tests |
There was a problem hiding this comment.
Legacy sounds good and let's wait for some inputs for native English speakers.
Co-authored-by: Wei Ji <[email protected]>
weiji14
changed the title
seisman
commented
Sep 9, 2022
| @@ -0,0 +1,105 @@ | |||
| # This workflow installs PyGMT and runs tests with old GMT versions | |||
There was a problem hiding this comment.
Remember to rename the workflow file if we decide to call it "GMT Legacy Tests"
weiji14
approved these changes
Sep 13, 2022
weiji14
added
final review call
willschlitzer
approved these changes
Sep 14, 2022
seisman
commented
Sep 14, 2022
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…sday (GenericMappingTools#2079) Co-authored-by: Max Jones <[email protected]> Co-authored-by: Wei Ji <[email protected]>
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
To test PyGMT with old GMT versions, a new Makefile target and a new workflow are added in this PR.
Makefile target
test_no_imagesBecause the baseline images usually have slight changes for different GMT versions, it makes little sense to compare the baseline images generated by GMT 6.4 when running the tests with GMT 6.3. However, we still want to run these image-building tests to make sure they don't crash or raise errors. This is done by NOT adding the
--mploption to pytest.New workflow "GMT Backwards Tests"
This workflow is modified from the "GMT Dev Tests" workflow. It will run when a PR is marked ready for review and will run every Tuesday.
Fixes #1991.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version