-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMTDataArrayAccessor: Fallback to default grid registration and gtype if the grid source file doesn't exist #2009
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
db3cbe5
Let GMTDataArrayAccessor check if the grid source file exists
seisman 4d060f0
Merge branch 'main' into check-dataarray-source
seisman bae08d1
Raise FileNotFoundError instead
seisman 37869d4
Add a unit test
seisman 7b0520a
Fix the test failure
seisman 031a5d1
Merge branch 'main' into check-dataarray-source
seisman 0e031e0
Test with sliced grid
seisman 6b36922
Merge branch 'main' into check-dataarray-source
seisman 9f48efc
Fix imports order
seisman 2b89224
Merge branch 'main' into check-dataarray-source
seisman cbe107f
Apply suggestions from code review
seisman 6bc113e
Refactor the codes for determining grid registration and gtype
seisman 4389aa1
Apply suggestions from code review
seisman ef79c20
Fix formatting
seisman 006350a
Apply suggestions from code review
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should change these lines to the following codes, which I think are more readable:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we will silently fallback to registration=0 and gtype=0 if
grdinfo
cannot determine the grid registration and type? Ok I guess, but please add the code comments back 🙂