Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixture import and docstring in test_filter1d.py #1962

Merged
merged 5 commits into from
Jun 28, 2022

Conversation

willschlitzer
Copy link
Contributor

I forgot to change the docstring in fixture_table() in test_filter1d.py from whatever grid loading function I copied it from. This updates the docstring to accurately describe the function.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Jun 15, 2022
@willschlitzer willschlitzer added this to the 0.7.0 milestone Jun 15, 2022
@willschlitzer willschlitzer self-assigned this Jun 15, 2022
@willschlitzer willschlitzer changed the title Fix incorrect docstring in test_filter1d.py Update fixture import and docstring in test_filter1d.py Jun 27, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jun 27, 2022
@seisman seisman merged commit d76aa2b into main Jun 28, 2022
@seisman seisman deleted the typo-fix/test_filter1d branch June 28, 2022 09:36
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants