Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yvonnefroehlich to AUTHORS.md #1958

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Add yvonnefroehlich to AUTHORS.md #1958

merged 2 commits into from
Jun 14, 2022

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

As proposed in PR#1934 comment this PR adds myself to the AUTHORS.md file.
Actually, I am a bit surprised about this and unsure, whether I contributed enough to be an author 😮. I am in principle open to contribute more 😊 (based on available time 😆), but for the sake of fairness I have to say, that I am not a programmer. Thus, my skills and knowledge are limited, when it comes to more complicated issues and tasks, like wrapping modules etc. 😉.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman
Copy link
Member

seisman commented Jun 14, 2022

Actually, I am a bit surprised about this and unsure, whether I contributed enough to be an author 😮.

See our Authorship Guidelines. You're definitely welcome to be added to the AUTHORS.md file.

I am in principle open to contribute more 😊 (based on available time 😆), but for the sake of fairness I have to say, that I am not a programmer. Thus, my skills and knowledge are limited, when it comes to more complicated issues and tasks, like wrapping modules etc. 😉.

Don't worry. I believe you'll learn a lot by contributing to the project!

@seisman seisman added this to the 0.7.0 milestone Jun 14, 2022
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Jun 14, 2022
@yvonnefroehlich
Copy link
Member Author

See our Authorship Guidelines. You're definitely welcome to be added to the AUTHORS.md file.
Don't worry. I believe you'll learn a lot by contributing to the project!

Sounds great!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 14, 2022
@seisman seisman merged commit 12cf87d into GenericMappingTools:main Jun 14, 2022
@weiji14
Copy link
Member

weiji14 commented Jun 14, 2022

Welcome @yvonnefroehlich!

@yvonnefroehlich yvonnefroehlich deleted the add-yvonnefroehlich-to-authors branch June 14, 2022 19:37
@yvonnefroehlich
Copy link
Member Author

Thanks @weiji14 for also adding me to the project on ResearchGate 😊 !

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants