Redesign the team gallery using sphinx-design's card directive #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
May 31, 2022
Co-authored-by: Dongdong Tian <[email protected]>
weiji14
reviewed
May 31, 2022
| </div> | ||
| </div> | ||
| ``` | ||
| :::::{grid} 2 3 3 4 |
There was a problem hiding this comment.
Is this for the margins? Feel like the vertical spacing between cards could be increased a bit. Right now there's not much of a gap.
compared to https://www.pygmt.org/v0.6.1/team.html:
There was a problem hiding this comment.
:::::{grid} 2 3 3 4
These four numbers are the number of columns for extra-small, small, medium and large screens.
maxrjones
reviewed
May 31, 2022
doc/team.md
Outdated
Comment on lines
76
to
77
| Maintainer | ||
| [@weiji14](https://github.com/weiji14) |
There was a problem hiding this comment.
Suggested change
| Maintainer | |
| [@weiji14](https://github.com/weiji14) | |
| [@weiji14](https://github.com/weiji14) | |
| +++ | |
| Maintainer |
| Before | After |
|---|
|
| 
|
There was a problem hiding this comment.
Good suggestion! I've used the footer option for labels and also use sphinx-design's badge directive to highlight different roles.
Co-authored-by: Wei Ji <[email protected]>
|
Here is the latest screenshot: |
weiji14
approved these changes
Jun 1, 2022
weiji14
added
the
final review call
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…icMappingTools#1937) Co-authored-by: Max Jones <[email protected]> Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Use sphinx-design's card directive instead of the unreadable raw HTML codes added in #1308.
The
carddirective can also be used in #1936.