Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inset: Add aliases for R and J and fix two examples #1931

Merged
merged 9 commits into from
Jun 26, 2022
Merged

inset: Add aliases for R and J and fix two examples #1931

merged 9 commits into from
Jun 26, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented May 24, 2022

Description of proposed changes

Fix two inset examples as pointed out in #1930 (comment).

Closes #1930.

@seisman seisman added the documentation Improvements or additions to documentation label May 24, 2022
@seisman seisman added this to the 0.7.0 milestone May 24, 2022
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement to this tutorial

@willschlitzer willschlitzer added the final review call This PR requires final review and approval from a second reviewer label May 24, 2022
examples/tutorials/advanced/insets.py Outdated Show resolved Hide resolved
pygmt/src/inset.py Outdated Show resolved Hide resolved
@seisman seisman marked this pull request as draft May 24, 2022 13:44
@seisman
Copy link
Member Author

seisman commented May 24, 2022

I mark the PR as a draft due to the concern/issue mentioned in #1930 (comment)

@seisman seisman changed the title Fix two inset examples Add aliases for R and J in inset and fix two examples May 27, 2022
@seisman seisman marked this pull request as ready for review May 27, 2022 01:50
@seisman seisman marked this pull request as draft May 27, 2022 01:55
@seisman
Copy link
Member Author

seisman commented May 27, 2022

As explained in GenericMappingTools/gmt#6751 (comment), a better solution is specifying -R and -J in inset begin so that inset can determine the inset width and height automatically. I think this is an intuitive solution and should be recommended, so I have updated the two examples accoordingly.

Unfortunately, -R and -J are not aliased in PyGMT v0.6.1, so this PR also adds the aliases for -R and -J.

Some TODOs:

Please let me know what you think before I start to work on them.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 27, 2022
@seisman seisman marked this pull request as ready for review June 9, 2022 08:23
@seisman seisman added the enhancement Improving an existing feature label Jun 23, 2022
@seisman seisman removed the documentation Improvements or additions to documentation label Jun 23, 2022
@seisman seisman mentioned this pull request Jun 24, 2022
26 tasks
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jun 24, 2022
@seisman seisman changed the title Add aliases for R and J in inset and fix two examples inset: Add aliases for R and J and fix two examples Jun 26, 2022
@seisman seisman merged commit c3ac955 into main Jun 26, 2022
@seisman seisman deleted the fix-inset branch June 26, 2022 13:07
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 26, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong point location in inset
3 participants