-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inset: Add aliases for R and J and fix two examples #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement to this tutorial
I mark the PR as a draft due to the concern/issue mentioned in #1930 (comment) |
As explained in GenericMappingTools/gmt#6751 (comment), a better solution is specifying -R and -J in inset begin so that inset can determine the inset width and height automatically. I think this is an intuitive solution and should be recommended, so I have updated the two examples accoordingly. Unfortunately, -R and -J are not aliased in PyGMT v0.6.1, so this PR also adds the aliases for -R and -J. Some TODOs:
Please let me know what you think before I start to work on them. |
…ols#1931) Co-authored-by: Michael Grund <[email protected]>
Description of proposed changes
Fix two inset examples as pointed out in #1930 (comment).
Closes #1930.