-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sample dataset notre_dame_topography #1920
Conversation
pygmt/datasets/samples.py
Outdated
@@ -30,6 +30,7 @@ def list_sample_data(): | |||
"mars_shape": "Table of topographic signature of the hemispheric dichotomy of " | |||
" Mars from Smith and Zuber (1996)", | |||
"ocean_ridge_points": "Table of ocean ridge points for the entire world", | |||
"table511": "Table 5.11 in Davis: Statistics and Data Analysis in Geology.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think table511
is a good name for this dataset, but I have no idea about the content of the dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason I went with table511
is because that is in line with the GMT remote dataset name. I also have no idea what the content is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulWessel Could you please explain what the Table_5_11.txt
file has?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes. My book is sitting on a shelf in Hawaii. I could answer in 12 days when I am back for a few weeks. But vague memory is that is it topography.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dataset is used in ex12 (https://docs.generic-mapping-tools.org/latest/gallery/ex12.html).
Our next example operates on a data set of topographic readings non-uniformly distributed in the plane (Table 5.11 in Davis: Statistics and Data Analysis in Geology, J. Wiley).
According to the example description, perhaps we can name the dataset as "unevenly_sampled_topography"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given John Davis worked for the Kansas Geological Survey I am guessing it is either in Kansas or this is Notre Dame University area in Indiana.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would notre_dame_topgraphy
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would
notre_dame_topgraphy
work?
Sounds a good name to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably meant notre_dame_topography ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! The dangers of getting on my computer pre-coffee.
Co-authored-by: Dongdong Tian <[email protected]>
/format |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
This adds
@table_5_11.txt
toload_sample_data()
.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version