Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_accessor_sliced_datacube as xfail due to upstream bug #1895

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 24, 2022

Description of proposed changes

GMT 6.3.0 doesn't work on 3D grid cubes (reported in GenericMappingTools/gmt#6588 (comment)).

In GMT 6.3.0, the grdinfo output is empty:

$ gmt grdinfo eraint_uvz.nc -Cn
grdinfo [WARNING]: Detected a data cube (eraint_uvz.nc) but -Q not set - skipping

After the upstream fix GenericMappingTools/gmt#6615, the output is:

$ gmt grdinfo eraint_uvz.nc -Cn
-180	179.25	-90	90	66825.5	66825.5	0.75	0.75	480	241	0	1

From the output, it's clear that the grid cube has registration=0 and gtype=1.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 24, 2022
@seisman seisman added this to the 0.7.0 milestone Apr 24, 2022
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Apr 24, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 25, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 25, 2022
@seisman seisman merged commit 3a371d0 into main Apr 25, 2022
@seisman seisman deleted the fix-accessor-datacube branch April 25, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants