Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing None explicitly to pygmt functions Part 3 #1872

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 6, 2022

Description of proposed changes

Address #1857 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs bug Something isn't working and removed maintenance Boring but important stuff for the core devs labels Apr 6, 2022
@seisman seisman added this to the 0.6.1 milestone Apr 6, 2022
@seisman seisman force-pushed the arg_is_not_None_Part3 branch from 0594aac to d0befd5 Compare April 6, 2022 14:57
@seisman seisman merged commit 3841bb6 into main Apr 7, 2022
@seisman seisman deleted the arg_is_not_None_Part3 branch April 7, 2022 00:18
@weiji14 weiji14 mentioned this pull request Apr 9, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants