Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let slash command /test-gmt-dev report job URL #1866

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Let slash command /test-gmt-dev report job URL #1866

merged 2 commits into from
Apr 6, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 4, 2022

Description of proposed changes

As reported in #1816:

The /test-gmt-dev command, I think it does run (?), but you have to jump to the 'Actions' tab to see it run which is very inconvenient.

This PR fixes the problem by adding the job URL to the PR comment.

See the PR https://github.com/seisman/pygmt/pull/2 in my own fork for how it works:

image

Fixes #1816.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 4, 2022
@seisman seisman added this to the 0.6.1 milestone Apr 4, 2022
@weiji14 weiji14 changed the title Let slash comamnd /test-gmt-dev report job URL Let slash command /test-gmt-dev report job URL Apr 5, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @seisman! Just one minor suggestion, otherwise looks good to me.

.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Apr 5, 2022
@seisman seisman merged commit d891361 into main Apr 6, 2022
@seisman seisman deleted the slash-job-url branch April 6, 2022 16:30
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 6, 2022
seisman added a commit that referenced this pull request Apr 14, 2022
seisman added a commit that referenced this pull request Apr 14, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format and test-gmt-dev slash commands not working properly
2 participants