-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test_grdtrack.py to use static_earth_relief #1762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
added
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
labels
Feb 22, 2022
23 tasks
maxrjones
reviewed
Feb 23, 2022
@weiji14, as the original author of these tests, what is your opinion on removing the tests than involve file i/o from this module? |
weiji14
reviewed
Mar 1, 2022
weiji14
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are green again! Big thanks @willschlitzer, and to the rest of the team too 😃
weiji14
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Mar 2, 2022
seisman
approved these changes
Mar 3, 2022
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Mar 3, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ls#1762) Co-authored-by: Meghan Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
test_grdtrack.py
to useload_static_earth_relief
. This also changes the list of points that are used ingrdtrack
testing, asridges.txt
was not within the bounds of the static file.This PR removes some of the tests that directly import the csv file or remote grid file, as the csv file is not applicable and testing of the grid import is accomplished in other tests.
Addresses #1684
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version