Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test_grdtrack.py to use static_earth_relief #1762

Merged
merged 14 commits into from
Mar 3, 2022

Conversation

willschlitzer
Copy link
Contributor

This modifies test_grdtrack.py to use load_static_earth_relief. This also changes the list of points that are used in grdtrack testing, as ridges.txt was not within the bounds of the static file.

This PR removes some of the tests that directly import the csv file or remote grid file, as the csv file is not applicable and testing of the grid import is accomplished in other tests.

Addresses #1684

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 22, 2022
@willschlitzer willschlitzer added this to the 0.6.0 milestone Feb 22, 2022
@willschlitzer willschlitzer self-assigned this Feb 22, 2022
pygmt/tests/test_grdtrack.py Outdated Show resolved Hide resolved
pygmt/tests/test_grdtrack.py Outdated Show resolved Hide resolved
pygmt/tests/test_grdtrack.py Outdated Show resolved Hide resolved
@maxrjones
Copy link
Member

@weiji14, as the original author of these tests, what is your opinion on removing the tests than involve file i/o from this module?

@maxrjones maxrjones requested a review from a team March 2, 2022 21:41
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green again! Big thanks @willschlitzer, and to the rest of the team too 😃

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 2, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 3, 2022
@seisman seisman merged commit c6036c4 into main Mar 3, 2022
@seisman seisman deleted the static-earth-relief/grdtrack branch March 3, 2022 02:04
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants