Change test_grdcontour.py to use static_earth_relief

[willschlitzer]

This modifies test_grdcontour.py to use load_static_earth_relief.

Addresses #1684

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
• If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[github-actions]

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status	Path
deleted	pygmt/tests/baseline/test_grdcontour_file.png
modified	pygmt/tests/baseline/test_grdcontour.png
modified	pygmt/tests/baseline/test_grdcontour_interval_file_full_opts.png
modified	pygmt/tests/baseline/test_grdcontour_labels.png
modified	pygmt/tests/baseline/test_grdcontour_slice.png

Image diff(s)

Added images

Modified images

Path	Old	New
test_grdcontour.png
test_grdcontour_interval_file_full_opts.png
test_grdcontour_labels.png
test_grdcontour_slice.png

Report last updated at commit 8a62136

[willschlitzer]

@GenericMappingTools/pygmt-maintainers Does test_grdcontour.py need to keep test_grdcontour_file()? I feel like it's not testing anything new, as the import functions are already tested in other functions, and plotting is tested by the other functions.

[maxrjones]

@GenericMappingTools/pygmt-maintainers Does test_grdcontour.py need to keep test_grdcontour_file()? I feel like it's not testing anything new, as the import functions are already tested in other functions, and plotting is tested by the other functions.

I agree with you that it's not needed.

[maxrjones]

The region in test_grdcontour_interval_file_full_opts also needs adjusting.