Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static_earth_relief to grd2cpt tests #1736

Merged
merged 5 commits into from
Feb 11, 2022
Merged

Conversation

willschlitzer
Copy link
Contributor

This modifies test_grd2cpt.py to use load_static_earth_relief.

Addresses #1684

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 10, 2022
@willschlitzer willschlitzer added this to the 0.6.0 milestone Feb 10, 2022
@willschlitzer willschlitzer self-assigned this Feb 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_grd2cpt.png

Image diff(s)

Added images

Modified images

Path Old New
test_grd2cpt.png

Report last updated at commit 8d7cbf2

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 11, 2022
@maxrjones maxrjones merged commit b046e99 into main Feb 11, 2022
@maxrjones maxrjones deleted the static-earth-relief/grd2cpt branch February 11, 2022 18:47
@maxrjones maxrjones removed the final review call This PR requires final review and approval from a second reviewer label Feb 11, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants