Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_static_earth_relief function for internal testing #1727

Merged
merged 12 commits into from
Feb 9, 2022

Conversation

willschlitzer
Copy link
Contributor

This PR adds the @static_earth_relief to functions in samples.py.

Addresses #1684 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the documentation Improvements or additions to documentation label Feb 6, 2022
@willschlitzer willschlitzer added this to the 0.6.0 milestone Feb 6, 2022
@willschlitzer willschlitzer self-assigned this Feb 6, 2022
@willschlitzer willschlitzer changed the title WIP: Add _load_static_earth_relief Add _load_static_earth_relief Feb 7, 2022
@willschlitzer willschlitzer marked this pull request as ready for review February 7, 2022 17:20
@willschlitzer willschlitzer requested a review from a team February 7, 2022 17:20
pygmt/tests/test_datasets_samples.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add @static_earth_relief to the cache.

pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@weiji14 weiji14 marked this pull request as draft February 8, 2022 14:55
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs and removed documentation Improvements or additions to documentation labels Feb 8, 2022
@willschlitzer willschlitzer changed the title Add _load_static_earth_relief Add load_static_earth_relief Feb 8, 2022
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I think the test function could go in either test_datasets_samples.py or test_helpers.py and am fine with whichever you think is more appropriate.

@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Feb 8, 2022
@willschlitzer
Copy link
Contributor Author

Looks good, thanks! I think the test function could go in either test_datasets_samples.py or test_helpers.py and am fine with whichever you think is more appropriate.

I think test_helpers.py makes more sense; moving the test

@willschlitzer willschlitzer marked this pull request as ready for review February 8, 2022 17:29
@seisman seisman changed the title Add load_static_earth_relief Add load_static_earth_relief function for internal testing Feb 9, 2022
@seisman seisman merged commit f17ddb3 into main Feb 9, 2022
@seisman seisman deleted the add-static-earth-relief branch February 9, 2022 12:51
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 9, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants