Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xarray.testing rather than pygmt.grdinfo in grdlandmask tests #1680

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

willschlitzer
Copy link
Contributor

Description of proposed changes

This PR refactors the pygmt.grdlandmask tests to use xarray.testing.assert_allclose() rather than pygmt.grdinfo() in preparation for the deprecation associated with better return values for grdinfo (#593).

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 20, 2021
@willschlitzer willschlitzer added this to the 0.6.0 milestone Dec 20, 2021
@willschlitzer willschlitzer self-assigned this Dec 20, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 21, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 22, 2021
@seisman seisman merged commit 7061dac into main Dec 22, 2021
@seisman seisman deleted the remove-grdinfo/grdlandmask branch December 22, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants