Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_rose_bools.png.dvc for GMT 6.3 #1655

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR updates the baseline image used for pygmt/tests/test_rose.py::test_rose_bools and pygmt/tests/test_rose.py::test_rose_deprecate_columns_to_incols to pass with GMT 6.3.

Part of #1644

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones mentioned this pull request Dec 13, 2021
31 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_rose_bools.png

Image diff(s)

Added images

Modified images

Path Old New
test_rose_bools.png

Report last updated at commit f85f385

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 14, 2021
@seisman seisman added this to the 0.6.0 milestone Dec 14, 2021
@weiji14
Copy link
Member

weiji14 commented Dec 14, 2021

This may be one of those times when https://github.blog/changelog/2021-10-27-pull-request-merge-queue-limited-beta/ might be handy. Requires an organization admin to enable though (i.e. @meghanrjones or @seisman).

@maxrjones
Copy link
Member Author

This may be one of those times when https://github.blog/changelog/2021-10-27-pull-request-merge-queue-limited-beta/ might be handy. Requires an organization admin to enable though (i.e. @meghanrjones or @seisman).

The sign-up link said that our organization is already on the wait-list - not sure how long that is.

@seisman
Copy link
Member

seisman commented Dec 14, 2021

FYI, I just signed up a few minutes ago.

@maxrjones maxrjones merged commit 002e288 into main Dec 14, 2021
@maxrjones maxrjones deleted the update-rose-baseline branch December 14, 2021 01:49
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants