-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to set the waiting time when displaying a preview image using an external viewer #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
Allow users to set the waiting time when showing the preview using an external viewer
Allow users to set the waiting time when displaying a preview image using an external viewer
Nov 8, 2021
seisman
force-pushed
the
Figure-show-waiting
branch
from
November 8, 2021 15:08
42b457f
to
e8c8f56
Compare
Co-authored-by: Will Schlitzer <[email protected]>
weiji14
reviewed
Nov 20, 2021
weiji14
approved these changes
Nov 20, 2021
weiji14
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Nov 20, 2021
seisman
commented
Nov 20, 2021
michaelgrund
approved these changes
Nov 21, 2021
willschlitzer
approved these changes
Nov 21, 2021
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Nov 22, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…sing an external viewer (GenericMappingTools#1618) Co-authored-by: Will Schlitzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #1061 for the detailed issue report and discussions.
This PR adds the
waiting
parameter to thelaunch_external_viewer
function. The default value is 0, so no waiting by default.As mentioned in #1061 (comment), the
launch_external_viewer
function is used at two places, one in theFigure.show()
function, another in theFigure.savefig()
function.Figure.show()
opens the preview image in the temporary directory, thus we need to set the waiting time to a non-zero value (waiting=0.5
works for most users) so the external viewer can open the preview image before the PyGMT session exits.Figure.savefig()
opens the image that was already saved in the current directory or elsewhere, and won't be deleted when the PyGMT session exits. Thus there is no need to set the waiting time here.Fixes #1061.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version