-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.5.0 #1594
Merged
Merged
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ad5736c
initial copy for v0.5.0 changelog
willschlitzer ef9c0ab
remove README update
willschlitzer 7c38c0c
update wording in maintenance changes
willschlitzer 5008840
change order and organization of items in change log
willschlitzer f82677b
update author list
willschlitzer 9253c96
add highlight
willschlitzer 7e3c372
update README.rst; no changes to author list
willschlitzer 8e6aa9f
add v0.5.0 to version_switch.js
willschlitzer 3c24d75
adding version v0.5.0 as the latest release instead of dev release
willschlitzer 0e54ddb
add dev release to PyGMT version table
willschlitzer d18ed2f
add wrapping 12 modules to highlights
willschlitzer 3fc66f8
Merge branch 'main' into release/v0.5.0
willschlitzer 009944d
Apply suggestions from code review
willschlitzer eddf8ad
move Yohai up in author list
willschlitzer dd46dc9
move Meghan up in author list
willschlitzer f20843f
Merge branch 'main' into release/v0.5.0
willschlitzer 1e03470
remove highlight of Python 3.10 support
willschlitzer bbbc0ac
update CITATION.cff
willschlitzer 1067dda
Apply suggestions from code review
willschlitzer 6e2aa0a
Apply suggestions from code review
willschlitzer 2787554
Apply suggestions from code review
willschlitzer 7b83134
Merge branch 'main' into release/v0.5.0
willschlitzer 4b7da9a
Update doc/changes.md
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Yohai has 7 commits, I think we should bump his name up the list (to be after Jiayuan) on the BibTeX and CITATION.cff file. This is what I get from
git shortlog -sne
(after merging duplicate entries):Also happy to debate on whether we switch any of the ordering (e.g. make @seisman first author 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either way of doing it. I know that we have previously put @leouieda at the front because he created this project, but I think @seisman, @weiji14, and @meghanrjones are the three most active on this project at this time when it comes to providing feedback and completing reviews. I moved both Meghan and Yohai up in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the order looks ok to me now (though happy to discuss). Please also update the CITATION.cff file with the new author order (and apply the patch from #1592 (comment)) as mentioned in #1594 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in bbbc0ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit late but just wanted to say that I'm perfectly happy not being first since @seisman @weiji14 @meghanrjones and others deserve it more than I do 👍🏽 Creating something is easy, keeping it going and growing like this is where the real work is 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leo for chiming in! I would argue that you still deserve the first spot since the original GMT C to Python interface (via ctypes) is so foundational (some of that 4+ year old code is still more or less intact at https://github.com/GenericMappingTools/pygmt/blame/v0.5.0/pygmt/clib/session.py and working!!!), and this is what makes this 'PyGMT' package so good compared to the other gmtpy/pygmt wrappers people have tried to come up with previously.
But again, I don't want to get into an author ordering debate, I'm just as happy being on third place, last place, alphabetically ordered or have a random number generator sort things out. We've discussed the AUTHORSHIP.md policy before at #726 (comment), and could edit it again if needed, especially when the time comes closer to getting a software publication out.