Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter 'table' to 'data' for gallery examples #1567

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Update parameter 'table' to 'data' for gallery examples #1567

merged 1 commit into from
Oct 5, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 4, 2021

Description of proposed changes

Address #1479.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Oct 4, 2021
@seisman seisman added this to the 0.5.0 milestone Oct 4, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 5, 2021
@seisman seisman merged commit 6895c7e into main Oct 5, 2021
@seisman seisman deleted the fix-table-to-data branch October 5, 2021 11:03
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Update parameter 'table' to 'data' for gallery examples (GenericMappi…
7722ffc 
…ngTools#1567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @maxrjones @weiji14