Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.plot: Reorder input parameters to "data, x, y" #1547

Merged
merged 10 commits into from
Oct 3, 2021
Merged

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Address #1479

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman changed the title Figure.plot: Reorder input parameters Figure.plot: Reorder input parameters to "data, x, y" Oct 2, 2021
@seisman seisman added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 2, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I removed the "maintenance" and "skip-changelog" labels and added the "deprecation" label because the change goes into the deprecation cycle.

@seisman
Copy link
Member

seisman commented Oct 2, 2021

@michaelgrund Still need to fix the test_plot_datetime test because it passes x, y, not x=x, y=y.

@michaelgrund
Copy link
Member Author

@michaelgrund Still need to fix the test_plot_datetime test because it passes x, y, not x=x, y=y.

Also adjusted some of the gallery examples in which x, y is passed instead of x=x, y=y.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 2, 2021
@weiji14 weiji14 merged commit a553d68 into main Oct 3, 2021
@weiji14 weiji14 deleted the plot-reorder-paras branch October 3, 2021 02:02
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Oct 3, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…Tools#1547)

* Update plot.py
* add decorator
* adjust test_plot_datetime
* adjust gallery examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants