Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @mars370d.txt remote file to download_test_data #1532

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR adds the @mars370d.txt remote cache file to the download_test_data function in pygmt/helpers/testing.py so that the file is cached for the CI.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 21, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After commenting line 6 in cache_data.yaml this PR looks good to me!

@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Sep 21, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 22, 2021
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to make this in #1420 🤦‍♂️

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 22, 2021
@seisman seisman merged commit d7c5564 into main Sep 22, 2021
@seisman seisman deleted the mars-helpers-testing branch September 22, 2021 11:02
@maxrjones
Copy link
Member Author

Forgot to make this in #1420 🤦‍♂️

It's not a problem. I didn't remember either and only realized because the CI showed a problem (yay, testing 😄).

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants