Let required_z check work on xarray.Dataset inputs #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify if-statement check in `data_kind` helper function to use `len(data.data_vars)` to check the shape of xarray.Dataset inputs. Added two regression tests in test_clib and test_blockm to ensure this works on both the low-level clib and high-level module APIs.
2 tasks
seisman
reviewed
Sep 19, 2021
Co-authored-by: Dongdong Tian <[email protected]>
seisman
approved these changes
Sep 20, 2021
seisman
added
the
final review call
weiji14
removed
the
final review call
5 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ls#1523) Modify if-statement check in `data_kind` helper function to use `len(data.data_vars)` to check the shape of xarray.Dataset inputs. Added two regression tests in test_clib and test_blockm to ensure this works on both the low-level clib and high-level module APIs. * Mention required_z parameter in docstring Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR modifies the if-statement check in
data_kindhelper function to uselen(data.data_vars)to check the shape ofxarray.Datasetinputs. Added two regression tests in test_clib and test_blockm to ensure this works on both the low-level clib and high-level module APIs.Originally posted by @weiji14 in #1478 (comment)
For a list of data formats supported by PyGMT, see #1268.
Patches #1478, addressing #1478 (comment).
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version