-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gallery example showing the usage of text symbols #1522
Conversation
This PR adds adds a gallery example that shows the usage of text symbols via ``Figure.plot()``
Is "text symbols" different from normal texts? Why not using the |
I expanded the docstring and added a further sentence that is used in the GMT docs explaining why to use text symbols. In my opinion we should at least mention that it's possible to plot text symbols also via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example looks good to me except a few suggestions.
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had an idea to spell out 'πgmt', but ok with this example too 😆
Nice idea but I think it's not possible to mix Symbols and standard text here. |
…ngTools#1522) Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
This PR adds a gallery example that shows the usage of text symbols via
Figure.plot()
.Preview at https://pygmt-git-gallery-text-symbols-gmt.vercel.app/gallery/symbols/text_symbols.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version