Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing aliases to pygmt.grdgradient #1515

Merged
merged 20 commits into from
Oct 28, 2021
Merged

Add missing aliases to pygmt.grdgradient #1515

merged 20 commits into from
Oct 28, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Sep 16, 2021 •
edited by weiji14
Loading

This is a follow up to #1269, and wraps additional parameters for grdgradient.

Fixes #1372

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the enhancement Improving an existing feature label Sep 16, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Sep 16, 2021
@willschlitzer willschlitzer self-assigned this Sep 16, 2021
@willschlitzer willschlitzer changed the title Add optional parameters to grdgradient WIP: Add optional parameters to grdgradient Sep 17, 2021
@willschlitzer willschlitzer changed the title WIP: Add optional parameters to grdgradient Add optional parameters to grdgradient Sep 17, 2021
@weiji14 weiji14 mentioned this pull request Sep 21, 2021
Closed
@weiji14 weiji14 added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature labels Oct 5, 2021
@willschlitzer willschlitzer changed the title Add optional parameters to grdgradient Add missing aliases to grdgradient Oct 5, 2021
@willschlitzer willschlitzer marked this pull request as ready for review October 5, 2021 18:50
@willschlitzer willschlitzer added the skip-changelog Skip adding Pull Request to changelog label Oct 5, 2021
maxrjones
maxrjones reviewed Oct 6, 2021
View reviewed changes
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
@willschlitzer willschlitzer mentioned this pull request Oct 7, 2021
Closed
35 tasks
weiji14
weiji14 reviewed Oct 27, 2021
View reviewed changes
pygmt/src/grdgradient.py Show resolved Hide resolved
pygmt/src/grdgradient.py Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
michaelgrund
michaelgrund reviewed Oct 28, 2021
View reviewed changes
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
maxrjones
maxrjones approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only comments are that I think parameters need to be wrapped in double back-ticks.

Please wait for a second approval since I made commits to the branch.

pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
@willschlitzer @michaelgrund @maxrjones
Apply suggestions from code review
6ddc91b 
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
@willschlitzer
Copy link
Contributor Author

@weiji14 @seisman Could I get a second review for this pull request before merging it?

weiji14
weiji14 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes needed, otherwise ok!

pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
pygmt/src/grdgradient.py Outdated Show resolved Hide resolved
@weiji14 weiji14 removed the skip-changelog Skip adding Pull Request to changelog label Oct 28, 2021
@weiji14 weiji14 changed the title Add missing aliases to grdgradient Add missing aliases to pygmt.grdgradient Oct 28, 2021
@weiji14 weiji14 merged commit 934f1d3 into main Oct 28, 2021
@weiji14 weiji14 deleted the add-params-grdgradient branch October 28, 2021 22:38
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @maxrjones
@michaelgrund @weiji14
Add missing aliases to pygmt.grdgradient (GenericMappingTools#1515)
766e03e 
Add missing aliases normalize (N), tiles (Q),
slope_file (S), coltypes (f) to pygmt.grdgradient.

Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgrund michaelgrund michaelgrund left review comments

@maxrjones maxrjones maxrjones approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees

@willschlitzer willschlitzer

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Expand grdgradient's aliases to include normalize (N)
4 participants
@willschlitzer @maxrjones @michaelgrund @weiji14