-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand table-like input options for sphdistance #1491
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
de206a3
Add table docstring to parameters list
willschlitzer 0e41a09
move sphdistance to tabular data section
willschlitzer 8dc55b6
Merge branch 'main' into sphdistance-fixes
willschlitzer 68fcb68
Update pygmt/src/sphdistance.py
willschlitzer 9422b51
change "table" to "data"
willschlitzer 10a1aee
add blank line to prevent Sphinx error
willschlitzer 663805f
run make format
willschlitzer b1d573f
add parameters for xy input
willschlitzer d434195
add test for xy inputs
willschlitzer 24a3c2a
Apply suggestions from code review
willschlitzer 7db2128
remove z parameter
willschlitzer b9591f8
Apply suggestions from code review
willschlitzer 9243a90
Merge branch 'main' into sphdistance-fixes
willschlitzer c6113a9
add reference to GMT docs
willschlitzer b3ad116
update table docstring
willschlitzer a314688
Update pygmt/src/sphdistance.py
willschlitzer 6f3956d
Merge branch 'main' into sphdistance-fixes
willschlitzer 97108f2
update cache list
willschlitzer b836da2
comment out line for data caching
willschlitzer b59620c
Update pygmt/src/sphdistance.py
willschlitzer aacfc71
Merge branch 'main' into sphdistance-fixes
willschlitzer 14b1dd7
Merge branch 'main' into sphdistance-fixes
willschlitzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here. Also, just noticed that this summary doesn't seem correct. It seems to suggest Voronoi polygons are created, but the output is a raster grid, not a vector polygon. Maybe follow https://docs.generic-mapping-tools.org/6.2/sphdistance.html.