Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a list to the 'incols' parameter for blockm, grdtrack and text #1475

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 30, 2021

Description of proposed changes

Arguments like incols=[1, 0, 2] should be supported.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the bug Something isn't working label Aug 30, 2021
@seisman seisman added this to the 0.5.0 milestone Aug 30, 2021
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Aug 31, 2021
@seisman seisman merged commit 2e74fa1 into main Sep 1, 2021
@seisman seisman deleted the fix-incols branch September 1, 2021 15:32
@weiji14 weiji14 added enhancement Improving an existing feature and removed bug Something isn't working labels Oct 4, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants