Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap grdhisteq #1433
Wrap grdhisteq #1433
Changes from all commits
b48cad9
1cf0a95
1dbfff5
e248dcd
e36c93a
67f4e41
556dc47
40fbbbe
e04ef8a
6602098
94fd588
cc6fde1
9cd2cbc
29f14e7
68e23dd
7512225
b8635ee
a021d30
d908c99
c528c66
2078120
a08c724
222cf82
2b69196
e3d0678
6f3e23f
b29ef79
d985b98
a41423a
b84c745
0338837
ed5a9ff
02ed8ce
0d1e6fb
c6d5368
eec3dc7
7031d93
d479a29
325f72c
d7c22e0
7cccc33
d6d8a69
4077f14
76ba9f0
32757d8
938b729
71ed9bb
492980f
09f1385
77937cf
c5afdcc
245c560
08f3d47
c5e430f
5017440
8b5fc49
ace9916
75f61e3
ad23923
25c1a28
8df3492
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should raise an exception here rather than give a warning? Sometimes people just ignore warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bit of a discussion about this following this comment #1284 (review). See #1284 (comment) for a specific discussion about raising a warning versus exception. I think we should follow that lead, although we could move this to a helper function to make it more clear that the logic is used for multiple modules.