-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tomli as a dependency in GMT Dev Tests #1401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
force-pushed
the
fix-ci-dev-tests
branch
from
July 31, 2021 02:56
56c1d9e
to
afe8719
Compare
weiji14
changed the title
WIP Debugging GMT dev tests pip install --pre step
WIP Temporarily add toml as a dependency in GMT Dev Tests
Jul 31, 2021
Need to use tomli instead of toml.
weiji14
changed the title
WIP Temporarily add toml as a dependency in GMT Dev Tests
WIP Temporarily add tomli as a dependency in GMT Dev Tests
Jul 31, 2021
weiji14
force-pushed
the
fix-ci-dev-tests
branch
from
August 5, 2021 00:21
86abbe4
to
ad1440b
Compare
weiji14
changed the title
WIP Temporarily add tomli as a dependency in GMT Dev Tests
Add tomli as a dependency in GMT Dev Tests
Aug 5, 2021
seisman
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think we should merge it before releasing v0.4.1.
weiji14
added
skip-changelog
Skip adding Pull Request to changelog
and removed
skip-changelog
Skip adding Pull Request to changelog
labels
Oct 3, 2021
5 tasks
6 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Adding tomli to fix the GMT Dev Tests breakages reported in GenericMappingTools#1392. This is a temporary measure until `pytest-cov` releases a new version > 2.12.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adding
tomli
to fix the GMT Dev Tests breakages reported in #1392. This is a temporary measure untilpytest-cov
releases a new version > 2.12.1 to incorporate the dependency fix in pytest-dev/pytest-cov#410.While looking into #1392, I noticed that theEdit: ok, usingpip install --pre ...
command inci_tests_dev.yaml
doesn't seem to produce any output in the GitHub Actions log (see e.g. https://github.com/GenericMappingTools/pygmt/runs/3206665246?check_suite_focus=true#step:7:4). So are thepip
packages actually being installed? Not sure if this is a bug introduced after #1105, so am investigating here.pip list
at 0a8ab3d shows that the pip packages are indeed installed.Fixes #1392
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version