Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fig.grd baseline images for GMT 6.2.0rc1 #1224

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 22, 2021

Description of proposed changes

Updates broken tests on GMT 6.2.0rc1 for fig.grdcontour, fig.grdfilter and pygmt.grd2cpt.

Note that the tests for fig.grdfilter are updates to the min/max values of the grid (and not baseline images). In GMT 6.1.1, the min/max values of a grdfiltered xarray.DataArray grid was slightly different to that of a NetCDF grid by a few decimal places (see #809), but this appears to be fixed so that the min/max values are exactly the same in GMT 6.2.0rc1 now. This resolves #859 I think, (originally fixed upstream at GenericMappingTools/gmt#5107).

This PR should also:

Addresses #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 22, 2021
@weiji14 weiji14 added this to the 0.4.0 milestone Apr 22, 2021
@weiji14 weiji14 self-assigned this Apr 22, 2021
@weiji14 weiji14 mentioned this pull request Apr 22, 2021
3 tasks
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_grd2cpt.png
modified pygmt/tests/baseline/test_grdcontour.png
modified pygmt/tests/baseline/test_grdcontour_file.png
modified pygmt/tests/baseline/test_grdcontour_interval_file_full_opts.png
modified pygmt/tests/baseline/test_grdcontour_labels.png
modified pygmt/tests/baseline/test_grdcontour_slice.png

Image diff(s)

Added images

Modified images

Path Old New
test_grd2cpt.png
test_grdcontour.png
test_grdcontour_file.png
test_grdcontour_interval_file_full_opts.png
test_grdcontour_labels.png
test_grdcontour_slice.png

Report last updated at commit c93cc99

@weiji14 weiji14 changed the title Update fig.grd baseline image for GMT 6.2.0rc1 Update fig.grd baseline images for GMT 6.2.0rc1 Apr 22, 2021
@weiji14 weiji14 marked this pull request as ready for review April 22, 2021 03:42
@weiji14 weiji14 merged commit 3a4f2f5 into master Apr 22, 2021
@weiji14 weiji14 deleted the gmt-6.2.0rc1/grd branch April 22, 2021 21:42
michaelgrund pushed a commit to michaelgrund/pygmt that referenced this pull request Apr 23, 2021
…1224)

* Update fig.grdcontour baseline images for GMT 6.2.0rc1
* Fix test_grdfilter tests for GMT 6.2.0rc1

Min/max values of the grid now matches properly for xarray.DataArray and NetCDF inputs.

* Update fig.grd2cpt baseline image for GMT 6.2.0rc1
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…1224)

* Update fig.grdcontour baseline images for GMT 6.2.0rc1
* Fix test_grdfilter tests for GMT 6.2.0rc1

Min/max values of the grid now matches properly for xarray.DataArray and NetCDF inputs.

* Update fig.grd2cpt baseline image for GMT 6.2.0rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
2 participants