Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dvc to CONTRIBUTING.md under Testing your code #1083

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR adds the necessary steps for getting the baseline images using dvc to the CONTRIBUTING.md guide in the 'Testing your code' section.

This change is not included in #1056 and is submitted as a separate pull request so as to not slow that PR down more by suggesting more changes.

Relates to #963

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones requested a review from weiji14 March 20, 2021 15:47
@maxrjones maxrjones added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 20, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 20, 2021
@weiji14 weiji14 merged commit 2dff597 into master Mar 20, 2021
@weiji14 weiji14 deleted the contrib-dvc branch March 20, 2021 21:15
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…MappingTools#1083)

Add the necessary steps for getting the baseline images
using `dvc` to the CONTRIBUTING.md guide under the
'Testing your code' section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants