Copy interval docs from grdcontour.py to the levels docs in contour.py #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Mar 13, 2021
pygmt/src/contour.py
Outdated
| levels : str or int | ||
| Specify the contour lines to generate. | ||
|
|
||
| - The filename of a `CPT` file where the color boundaries will |
There was a problem hiding this comment.
Suggested change
| - The filename of a `CPT` file where the color boundaries will | |
| - The filename of a CPT file where the color boundaries will |
There was a problem hiding this comment.
@willschlitzer Could you also make the same fix in grdcontour.py?
There was a problem hiding this comment.
Done in 50fbf4e
Co-authored-by: Dongdong Tian <[email protected]>
|
Is the no approval for this and #1044 a GitHub bug or a force merge? |
|
It's a simple fix so I just pushed the "force merge" button (after reviewing the changes 😃) |
OK, sounds good. I just wanted to make sure we weren't have any GitHub problems after the issues yesterday. |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
GenericMappingTools#1043) Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @meghanrjones in #1042, the parameter
levelsincontour.pyis the same asintervalingrdcontour.py. Theintervaldocumentation was much more complete than thelevelsdocumentation; this pull request copies the documentation fromintervaltolevels.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version