Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apprently new VS headers (or other Win .h) drop "#define NAN". #8627

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

joa-quim
Copy link
Member

This PR defines it when it«s not found (Windows only)

This PR defines it when it«s not found (Windows only)
@seisman
Copy link
Member

seisman commented Nov 20, 2024

NAN is handled in

# define NAN _Nan._Double

Perhaps _Nan._Double is not a constant?

@joa-quim
Copy link
Member Author

I don't know where _Nan._Double is coming from, but since my previous fix seems to solve it (the Win CI built fine), I now moved that NAN definition to gmt_notposix.h

@seisman
Copy link
Member

seisman commented Nov 20, 2024

_Nan was originally defined in ymath.h but was moved to another file in microsoft/STL#2828.

@joa-quim
Copy link
Member Author

Deeper than ymath.h. There I looked, but it includes others, that include others ...

@joa-quim joa-quim merged commit bfdd58d into master Nov 20, 2024
15 of 18 checks passed
@joa-quim joa-quim deleted the backup-def-NAN branch November 20, 2024 14:02
seisman added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants