Enable longoptions support for grd2xyz. #8178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joa-quim
reviewed
Dec 11, 2023
src/longopt/grd2xyz_inc.h
Outdated
| GMT_TP_STANDARD }, | ||
| { 0, 'E', "", | ||
| "", "", | ||
| { 0, 'L', "single", |
There was a problem hiding this comment.
hvline means horizontal or vertical line of the matrix. Not perfect but I don't find single (what?) particularly better.
There was a problem hiding this comment.
Maybe --array is better. There is no line perse anyway, and what is retired is a vector or array.
|
Please add array to the alias hvline and then we are good. |
PaulWessel
approved these changes
Jan 21, 2024
src/longopt/grd2xyz_inc.h
Outdated
| GMT_TP_STANDARD }, | ||
| { 0, 'E', "", | ||
| "", "", | ||
| { 0, 'L', "single", |
There was a problem hiding this comment.
Maybe --array is better. There is no line perse anyway, and what is retired is a vector or array.
remkos
added a commit
that referenced
this pull request
Jan 23, 2024
* 'master' of https://github.com/GenericMappingTools/gmt: (24 commits) Bump actions/cache from 3 to 4 (#8323) Add longoptions support for psbarb. (#8283) Add longoptions support for nearneighbor. (#8281) Add longoptions support for makecpt. (#8280) Add longoptions support for kml2gmt. (#8279) Add longoptions support for inset. (#8278) Add longoptions support for grdvolume. (#8276) Add longoptions support for grdview. (#8275) Batch #8 of longoptions translation tests. (#8272) Enable longoptions support for grdconvert. (#8197) Enable longoptions support for grd2xyz. (#8178) Update gmt_init.c Allow -A even if movie is not generated typos Update std-opts.rst Same case, clearer titles Dateline crossing dcw polygons and tiles (#8318) Missed a space before -T synopsis Improve windbarb docs, synopsis and usage for -Q and parsing of -Q (#8314) Let grdmix create RGB imagea for red, green, blue grids in 0-255 range (#8316) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Python differences:
Changed -C cstyle to rowcol (--cstyle+fortran would be very confusing).
Changed -Z convention (convention concerning what?) to ordering.
Julia differences:
Changed -L hvline (???) to single.
Removed -T STL alias (no uppercase first character allowed for any
longoption trigger string).
Fixes #
Reminders