Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if @N etc is at start of OGR/GMT line #7713

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Check if @N etc is at start of OGR/GMT line #7713

merged 2 commits into from
Aug 11, 2023

Conversation

PaulWessel
Copy link
Member

Closes #7712. Must allow strings starting with @ once the initial line-check finds a @ code.

Closes #7712. Must allow strings starting with @ once the initial line-check finds a @ code.
@PaulWessel PaulWessel added bug Something isn't working enhancement Improving an existing feature labels Aug 11, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Aug 11, 2023
@PaulWessel PaulWessel requested a review from seisman August 11, 2023 09:36
@PaulWessel PaulWessel self-assigned this Aug 11, 2023
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@PaulWessel
Copy link
Member Author

Thinking of also checking for upper case codes only. The GMT/OGR manual does not say we can use @n so that can be skipped, no?

@seisman
Copy link
Member

seisman commented Aug 11, 2023

Thinking of also checking for upper case codes only. The GMT/OGR manual does not say we can use @n so that can be skipped, no?

Makes sense to me.

@PaulWessel PaulWessel merged commit 0499169 into master Aug 11, 2023
@PaulWessel PaulWessel deleted the ogr-token branch August 11, 2023 14:02
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog bug Something isn't working enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OGR/GMT: Error when parsing strings that contain the special @ characters
3 participants