Do not allow -Xc|f in modern mode #7304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A handful of stray modern mode scripts had -Xc which does northing to affect the final cropped plot but does cause faiilure when comparing to orig PS. I will update those few PS in dvc after this is done,
PaulWessel
added
documentation
seisman
reviewed
Mar 7, 2023
Co-authored-by: Dongdong Tian <[email protected]>
seisman
approved these changes
Mar 7, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of stray modern mode scripts had left-over -Xc settings which does northing to affect the final cropped plot but does cause failure when comparing to orig PS since those are US letter size and the -Xc shifts things. I have updated those few PS in dvc after removing the -Xc and recreating the outputs. Other scripts were not affected and tests are similarly working. The documentation and usage message now mention the limitation in modern mode.