-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let gmt end better handle -A args #5583
Conversation
See #5582 for background. This minor change allows the margins and other settings such as +g, +f, etc.
The key problem is that -A was initially created to do cropping, but then I had lots of other features I wanted added, such as controlling paper color, outlines, margins, scaling, etc, and they all got added to -A. However, none of those modifers are really about cropping, so we added +n to say no crop as well. It should be possible to use +m to add margins to a cropped image and an uncropped image. This is what is failing right now. I wonder if it may be best to let -A with no args turn on cropping (finding the BB) while a -A with arguments does not turn on cropping, and the two can be combined when we want cropping and margin, for example. Wonder if @joa-quim is around to opine on this? |
Also fixed errors is the use of GMT_Report.
I have completed the upgrade to psconvert (and gmt end as well) to handle the new options:
Tests pass and my map that wants to add 0.125i bleed (margin) to the fixed media now works as well. I few notes of things done during the updates:
The only thing I have not tested is any potential issues when -W is used. Hoping @joa-quim can check for compliance before we remove the WIP. |
Many changes to eye follow. Maybe come out with long-options name for -N & -I |
We have had -A+gfill forever and not sure if pS_PAGE_COLOR=rgb works the same way when you extend the region. I will try. |
Yes, you can do --PS_PAGE_COLOR or you can do -N+g. I think we added it because it was simpler. |
gmt begin options documentation needs updating too, since the new I and N options should be available. As a GMT user, I would find it helpful to have these deprecations included in the changelog. What do you think of having an additional deprecation section? From a maintenance perspective, it would just mean having another label 'deprecation' and using the 'add-changelog' label for PRs such as this, as well as using descriptive PR titles as per usual. We could adjust the release-drafter workflow to do the rest. |
I think that would go useful, too. I suspect most GMT users are resistant to changing how they use GMT and only notice if there is a deprecation if they get a compatibility warning. But they wont get those after we changed the verbosity levels to place compatibility further down the list and beyond the default. |
As well as for -A. Perhaps -A: --crop[+timestamp][+round] |
Not sure if I am missing something from the documentation but I cannot get -N+ffade to do anything:
Also, a new notice shows up from gmt end in this PR. |
I think it is only meant to be used via movie (fade in fade out). But I will check. |
I remove the temporary NOTICE message. |
Sure, but |
@joa-quim any issues with -W that you can detect? I dont have any good examples to try. As mentioned, the only potential issue would be related to -A+n now being -W+c. You may recall that using -W automatically sets -A -P and we added -A+n to turn -A off, basically, which is an odd way of doing things. The -W+c is better in that sense. But not tested. |
Try the Patagonia example in the |
Will do. |
Patagonia example worked, I could import that geotiff in Google Earth Pro and it obliquely laid down and fit the background. So I will merged shortly. |
See #5582 for background. This minor change allows the margins and other -A modifiers such as +g, +f, etc.