-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let -Jp|P optionally set what angles"w/e" really are #5124
Conversation
Since we cannot tell what the angles are we default to great-circle angles (0-360 or -180/80 depending on FORMAT_GEO_MAP setting unless users add +kx to select longitude annotations or +ky for latitude annotations. The latter restricts -R to be within -90/90 range.
This PR yields these failures:
because they previously all were assumed to be longitudinal crossections for a north pole but in this PR we do not make that assumption. So either (1) add +kx to these examples and then they will pass, or (2) update some scripts/plots to allow for +kx and +ky as well. |
@PaulWessel, should I review this now or is more work needed first? |
Not yet, working on the labels. |
This PR is good to be reviewed. It contains these changes:
All tests pass for me. |
See #5120 for background. Since we cannot tell what the angles are we default to great-circle angles (0-360 or -180/80 depending on FORMAT_GEO_MAP setting, and append the degree symbol) unless users add +kx to select longitude annotations or +ky for latitude annotations. The latter also requires -R to be within -90/90 range.
I labelled this WIP for now since we have to decide if this is a bug fix or a feature that should be included in 6.2.0.
Closes #5120.