Fix GMT_LIBDIR_RELATIVE for Windows #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the gmt.dll is located in the `bin` directory, instead of the usual `lib` directory. Thus, for windows, we need to set `GMT_LIBDIR_RELATIVE` to `bin`. Closes #3353.
Merged
5 tasks
PaulWessel
approved these changes
May 20, 2020
seisman
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
May 20, 2020
The variable GMT_SHAREDIR was needed due to a GMT bug. See GenericMappingTools/gmt#3353 for the bug report, and GenericMappingTools/gmt#3361 for the fix. The conda GMT package was rebuilt in conda-forge/gmt-feedstock#94, in which the patch was applied to GMT 6.0.0. Now PyGMT should work well with no need to add the variable GMT_SHAREDIR.
5 tasks
seisman
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
May 20, 2020
The variable GMT_SHAREDIR was needed due to a GMT bug. See GenericMappingTools/gmt#3353 for the bug report, and GenericMappingTools/gmt#3361 for the fix. The conda GMT package was rebuilt in conda-forge/gmt-feedstock#94, in which the patch was applied to GMT 6.0.0. Now PyGMT should work well with no need to add the variable GMT_SHAREDIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the gmt.dll is located in the
bindirectory, instead ofthe usual
libdirectory. Thus, for windows, we need to setGMT_LIBDIR_RELATIVEtobin.Closes #3353.