-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server files to remove extra whitespaces #49
Conversation
I use this command to remove the extra whitespaces: And this to reduce the decimals to 6 values The later was only applied to: BV, ER, ET, SD, SS, TF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks fine.
I see that there is a conflict. It seems my local branch don't have the latest changes. For the RU.txt and CHU.txt files I manually updated. The same for the DE.txt and NL.txt (in Europe). Not sure how should I proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am basically approving these blind since it is too much work to build the netcdf and a new version and test it...
I finished updating all the files. For the 5 files that have conflicts (RU, CHU, DE, NL, FJ) I carefully modify them considering the last changes. |
@PaulWessel maybe now you could create the netcdf to test it. |
Will try tomorrow Thursday. |
Looks like you either did not update master before you started on this branch? The config.mk file says 2.0.1, for instance while master says 2.0.2. |
There's two options given the size of the changes:
Would you want me to take one of those actions to resolve the merge conflicts, @Esteban82? |
Let's do 2) to be completely sure. |
OK, I merged in master accepting all incoming changes. You'll need to do a |
I think that everything is ready now. |
Should we write something in the changelog? |
You could add an entry like "Reformat original files using consistent format and white-space" so that in the future we at least will remember this happened should something odd show up later |
So do that, and then you can merge since already approved. |
See #38.
I update the AF files. Please let me know if I make the PR ok (it is the first time I am doing it from VSC).