feat: return structured mutation and insertion responses #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+53
to
+57
| val mutation = if (referenceGenomeSchema.isSingleSegmented()) { | ||
| it.mutation | ||
| } else { | ||
| "${it.sequenceName}:${it.mutation}" | ||
| } |
There was a problem hiding this comment.
@Taepper should we move this logic to SILO, too?
2 tasks
fengelniederhammer
force-pushed
the
718-return-mutations-and-insertions-as-structured-data
branch
from
f1328a9 to
da3e27a
Compare
JonasKellerer
approved these changes
Apr 2, 2024
lapis2/src/main/kotlin/org/genspectrum/lapis/openApi/OpenApiDocs.kt
Outdated
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
718-return-mutations-and-insertions-as-structured-data
branch
2 times, most recently
from
b44883c to
7d832dd
Compare
fengelniederhammer
force-pushed
the
718-return-mutations-and-insertions-as-structured-data
branch
from
7d832dd to
0a5a7be
Compare
fengelniederhammer
deleted the
718-return-mutations-and-insertions-as-structured-data
branch
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #718
resolves #710
builds on GenSpectrum/LAPIS-SILO#373
PR Checklist