Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt response structure of LAPIS 2 to LAPIS 1 #324

Closed
fengelniederhammer opened this issue Aug 9, 2023 · 0 comments · Fixed by #325
Closed

Adapt response structure of LAPIS 2 to LAPIS 1 #324

fengelniederhammer opened this issue Aug 9, 2023 · 0 comments · Fixed by #325
Assignees
Labels
LAPIS Tasks/PR related to LAPIS
Milestone

Comments

@fengelniederhammer
Copy link
Contributor

LAPIS 2 currently simply returns the data as they are.

LAPIS 1 returns some additional information and the data wrapped in a "data" field:

{
    "errors": [],
    "info": {
        "apiVersion": 1,
        "dataVersion": 1691410888,
        "deprecationDate": null,
        "deprecationInfo": null,
        "acknowledgement": null
    },
    "data": [
        {
            "date": "2023-07-16",
            "count": 1
        },
        ...
    ]
}

Wrap the response data in a data field, so that we can easily extend it later with further information without breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant