Skip to content

Commit

Permalink
ci(lapis-docs): don't cache playwright browsers to simplify build
Browse files Browse the repository at this point in the history
The cache broke the build because something was outdated.
I'd rather have ci that runs a little longer than a more complicated build setup to maintain.
  • Loading branch information
fengelniederhammer committed Oct 15, 2024
1 parent ba18956 commit 7b51a54
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/lapis-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,27 +66,11 @@ jobs:
env:
IMAGE: ${{ steps.dockerMetadata.outputs.tags }}

- name: Get Installed Playwright Version
id: playwright-version
run: echo "PLAYWRIGHT_VERSION=$(node -e "console.log(require('./package-lock.json').packages['node_modules/@playwright/test'].version)")" >> $GITHUB_ENV

- name: Cache Playwright Browsers
uses: actions/cache@v4
id: playwright-cache
with:
path: ~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}

- name: Install Dependencies
run: npm ci

- name: Install Playwright Browsers
run: npx playwright install --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'

- name: Install only System Dependencies
run: npx playwright install-deps
if: steps.playwright-cache.outputs.cache-hit == 'true'

- name: Run E2E test
run: npm run e2e
Expand Down

0 comments on commit 7b51a54

Please sign in to comment.